feat(mcp): add claude-code support#295
Open
mrtam wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Claude Code as a supported cloudsmith mcp configure target and introduces safer JSON update helpers for MCP client config files.
Changes:
- Adds
claude-codeclient detection and global/local config paths. - Routes Claude Code configuration to
~/.claude.jsonor project.mcp.json. - Reworks config writes through atomic JSON update helpers with tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
cloudsmith_cli/cli/commands/mcp.py |
Adds Claude Code support and JSON safe-write helpers. |
cloudsmith_cli/cli/tests/commands/test_mcp.py |
Adds coverage for Claude Code configuration and atomic/safe update behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cloudsmith-iduffy
approved these changes
May 18, 2026
BartoszBlizniak
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
claude-codeas a supportedcloudsmith mcp configuretarget.Type of Change
Additional Notes
Made some changes to detect if a config file has been changed prior to writing, to then re-read that file. Particularly with
.claude.json, we need to ensure we're not overwriting stuff.