Skip to content

feat(mcp): add claude-code support#295

Open
mrtam wants to merge 2 commits into
masterfrom
claude-code-mcp
Open

feat(mcp): add claude-code support#295
mrtam wants to merge 2 commits into
masterfrom
claude-code-mcp

Conversation

@mrtam
Copy link
Copy Markdown
Member

@mrtam mrtam commented May 18, 2026

Description

Add claude-code as a supported cloudsmith mcp configure target.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Other (please describe)

Additional Notes

Made some changes to detect if a config file has been changed prior to writing, to then re-read that file. Particularly with .claude.json, we need to ensure we're not overwriting stuff.

Copilot AI review requested due to automatic review settings May 18, 2026 17:57
@mrtam mrtam requested a review from a team as a code owner May 18, 2026 17:57
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Claude Code as a supported cloudsmith mcp configure target and introduces safer JSON update helpers for MCP client config files.

Changes:

  • Adds claude-code client detection and global/local config paths.
  • Routes Claude Code configuration to ~/.claude.json or project .mcp.json.
  • Reworks config writes through atomic JSON update helpers with tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
cloudsmith_cli/cli/commands/mcp.py Adds Claude Code support and JSON safe-write helpers.
cloudsmith_cli/cli/tests/commands/test_mcp.py Adds coverage for Claude Code configuration and atomic/safe update behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cloudsmith_cli/cli/commands/mcp.py
Comment thread cloudsmith_cli/cli/commands/mcp.py
Comment thread cloudsmith_cli/cli/commands/mcp.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants